From 102329040db63147a96374164817ec2d0fd08a30 Mon Sep 17 00:00:00 2001 From: Dave Hansen-Lange <1127349+dalin-@users.noreply.github.com> Date: Thu, 7 Nov 2019 11:30:04 -0500 Subject: [PATCH 1/4] Use smooth scrolling so that animations are properly triggered. --- capture/engine_scripts/chromy/clickAndHoverHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/capture/engine_scripts/chromy/clickAndHoverHelper.js b/capture/engine_scripts/chromy/clickAndHoverHelper.js index d1af6ea63..3fa8ff474 100644 --- a/capture/engine_scripts/chromy/clickAndHoverHelper.js +++ b/capture/engine_scripts/chromy/clickAndHoverHelper.js @@ -37,7 +37,7 @@ module.exports = function (chromy, scenario) { .wait(scrollToSelector) .evaluate(`window._scrollToSelector = '${scrollToSelector}'`) .evaluate(function () { - document.querySelector(window._scrollToSelector).scrollIntoView(); + document.querySelector(window._scrollToSelector).scrollIntoView({behavior: "smooth"}); }); } }; From 5155f2866350d8285d9cb880bed584f3fc69c6ee Mon Sep 17 00:00:00 2001 From: Dave Hansen-Lange <1127349+dalin-@users.noreply.github.com> Date: Thu, 7 Nov 2019 11:30:59 -0500 Subject: [PATCH 2/4] Use smooth scrolling so that animations are properly triggered. --- capture/engine_scripts/puppet/clickAndHoverHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/capture/engine_scripts/puppet/clickAndHoverHelper.js b/capture/engine_scripts/puppet/clickAndHoverHelper.js index c7b0616f1..b2776d7fa 100644 --- a/capture/engine_scripts/puppet/clickAndHoverHelper.js +++ b/capture/engine_scripts/puppet/clickAndHoverHelper.js @@ -33,7 +33,7 @@ module.exports = async (page, scenario) => { if (scrollToSelector) { await page.waitFor(scrollToSelector); await page.evaluate(scrollToSelector => { - document.querySelector(scrollToSelector).scrollIntoView(); + document.querySelector(scrollToSelector).scrollIntoView({behavior: "smooth"}); }, scrollToSelector); } }; From 1564e1303cc47b8fbeeb79abf7a6d6df3081b5ef Mon Sep 17 00:00:00 2001 From: Dave Hansen-Lange <1127349+dalin-@users.noreply.github.com> Date: Fri, 8 Nov 2019 14:40:27 -0500 Subject: [PATCH 3/4] Fixed linting issues. --- capture/engine_scripts/chromy/clickAndHoverHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/capture/engine_scripts/chromy/clickAndHoverHelper.js b/capture/engine_scripts/chromy/clickAndHoverHelper.js index 3fa8ff474..4f3527e6c 100644 --- a/capture/engine_scripts/chromy/clickAndHoverHelper.js +++ b/capture/engine_scripts/chromy/clickAndHoverHelper.js @@ -37,7 +37,7 @@ module.exports = function (chromy, scenario) { .wait(scrollToSelector) .evaluate(`window._scrollToSelector = '${scrollToSelector}'`) .evaluate(function () { - document.querySelector(window._scrollToSelector).scrollIntoView({behavior: "smooth"}); + document.querySelector(window._scrollToSelector).scrollIntoView({ behavior: 'smooth' }); }); } }; From da358ead4ad74db7ca820f4babc2fd4de2ba2113 Mon Sep 17 00:00:00 2001 From: Dave Hansen-Lange <1127349+dalin-@users.noreply.github.com> Date: Fri, 8 Nov 2019 14:40:50 -0500 Subject: [PATCH 4/4] Fixed linting issues. --- capture/engine_scripts/puppet/clickAndHoverHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/capture/engine_scripts/puppet/clickAndHoverHelper.js b/capture/engine_scripts/puppet/clickAndHoverHelper.js index b2776d7fa..e7cdd3579 100644 --- a/capture/engine_scripts/puppet/clickAndHoverHelper.js +++ b/capture/engine_scripts/puppet/clickAndHoverHelper.js @@ -33,7 +33,7 @@ module.exports = async (page, scenario) => { if (scrollToSelector) { await page.waitFor(scrollToSelector); await page.evaluate(scrollToSelector => { - document.querySelector(scrollToSelector).scrollIntoView({behavior: "smooth"}); + document.querySelector(scrollToSelector).scrollIntoView({ behavior: 'smooth' }); }, scrollToSelector); } };