Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic clean up of bitmaps_test directory #814

Open
wlsf82 opened this issue Jun 26, 2018 · 6 comments · May be fixed by #836
Open

Automatic clean up of bitmaps_test directory #814

wlsf82 opened this issue Jun 26, 2018 · 6 comments · May be fixed by #836

Comments

@wlsf82
Copy link
Contributor

wlsf82 commented Jun 26, 2018 •
edited
Loading

Hi @garris,
Do you have any plans for implementing a feature where the bitmaps_test directory would be automatically cleared before running the tests?
@garris
Copy link
Owner

garris commented Jun 26, 2018 •
edited
Loading

Running backstop reference cleans out the reference directory and then creates brand new references. Is that what you mean?

https://github.com/garris/BackstopJS#creating-reference-files

@wlsf82 wlsf82 changed the title Automatic clean up of bitmaps_reference directory Automatic clean up of bitmaps_test directory Jun 26, 2018
@wlsf82
Copy link
Contributor Author

wlsf82 commented Jun 26, 2018

Sorry, @garris, I wrote it wrong and have updated it now. I meant the bitmaps_test directory.

@garris
Copy link
Owner

garris commented Jun 28, 2018

Oh sure. Yes, from time to time someone brings this up and everyone agrees it would be awesome to have but so far no one has implemented it.

One idea I like is to pass an argument like - -purgeTestsAfterNDays=<n> On the CLI. Or maybe add this to the config. Etc. adding a purge command would also be cool.

@wlsf82
Copy link
Contributor Author

wlsf82 commented Jun 28, 2018 •
edited
Loading

I'd prefer some configuration like cleanupBitmapsTestDir that would receive a boolean.

@garris
Copy link
Owner

garris commented Jun 28, 2018

A value of zero would delete everything. An undefined would keep everything. That doesn’t work?

@wlsf82
Copy link
Contributor Author

wlsf82 commented Jun 28, 2018

Yeah, that would work for me.

@brendonbribeiro brendonbribeiro linked a pull request Aug 13, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding automatic clean up of bitmaps_test directory option
2 participants
@garris @wlsf82