Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added team page #256

Closed
wants to merge 1 commit into from
Closed

Added team page #256

wants to merge 1 commit into from

Conversation

fatma-sia27
Copy link

@fatma-sia27 fatma-sia27 commented Apr 25, 2021

Fixes: #218

Hey as assigned isssue#218 , I had created an team page for the website . Please review it .
Thank you.

@Jagrati-Bot
Copy link
Collaborator

Congratulations for making your first Pull Request at JagratiWebApp!! 🎉 Someone from our team will review it soon.

@garg3133 garg3133 linked an issue May 1, 2021 that may be closed by this pull request
@fatma-sia27
Copy link
Author

@garg3133 , please review this PR.
Thank you

@fatma-sia27
Copy link
Author

@garg3133 please review my pr , gssoc period is about to end plss review it🙏🙏

Copy link
Owner

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatma-sia27 Really sorry for the delay. I was away from keyboard for the last few weeks due to some COVID emergency in my family.

Taking a look at your PR, while the page you designed looks really pleasing as a standalone page, it does not quite match with the overall theme of the site (no header, footer among other things). And the side banner containing the logo is taking too much width the adding more contributors to the list is going to make the page too long (maybe having that banner at the top would be better).

But these are kind of secondary issues, the primary issue here is that you cannot access this page from the django app, it is a standalone page. You should first integrate this page with the Django app (See other pages, how they are written).

  • Extend this page to base.html.
  • Keep all the images and CSS/JS files in the static directory (you've copied the images to the templates directory) and reference them using {% static 'path-with-respect-to-static-directory' %}.
  • Remove all the unnecessary files (like the contact.us1.html).
  • Create a new URL endpoint for team in home/urls.py and the corresponding view in home/views.py which will be used to render the page you just created.

@fatma-sia27
Copy link
Author

fatma-sia27 commented May 19, 2021

Hey @garg3133 , inside static directory there are many folders like accounts, global, home, new_home, logo etc. So in which folder should I put my html and css files?

@garg3133
Copy link
Owner

@fatma-sia27 Inside the home directory.

@fatma-sia27 fatma-sia27 closed this by deleting the head repository Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On opening TEAM page nothing is opening
3 participants