Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gardener integration tests on GCP #45

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

MrBatschner
Copy link
Member

What this PR does / why we need it:

Adds code support Gardener integration tests on GCP, similar to the changes in #38, #28 and #25.

This includes code to clean up images that were published on GCP based on their name and some minor changes to make the publishing process more resilient and the code a little more descriptive.

Release note:

The glci publishing gear now supports publishing and cleaning of temporary artefacts in GCP so that they can be used in Gardener integration tests.

@MrBatschner MrBatschner requested review from a team as code owners February 16, 2024 14:21
This allows glci to be used in the Gardener
integration test pipeline for GCP as well.
While at it, the names of some functions
related to GCP were changed to make them
more descriptive.
@MrBatschner MrBatschner changed the title add cleanup code for GCP Support for Gardener integration tests on GCP Feb 16, 2024
Copy link
Contributor

@Vincinator Vincinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry - don't know why I didn't approve sooner. looked at it last week and LGTM

@MrBatschner MrBatschner merged commit 931da26 into main Feb 28, 2024
@MrBatschner MrBatschner deleted the cleanup-gcp branch February 28, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants