Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce verify target #930

Open
1 of 7 tasks
aaronfern opened this issue Jul 12, 2024 · 1 comment
Open
1 of 7 tasks

Introduce verify target #930

aaronfern opened this issue Jul 12, 2024 · 1 comment
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@aaronfern
Copy link
Contributor

aaronfern commented Jul 12, 2024

How to categorize this issue?

/area ops-productivity
/kind enhancement
/priority 3

What would you like to be added:
Currently we have three separate make targets that we want to run before we merge a PR or say that a PR is ready to be consumed

  • make check
  • make build
  • make test

Since we need all three to run and pass, we can combine them into a single target make verify. This target should run all the above mentioned make targets

Why is this needed:
This is needed to consolidate multiple make targets. This will also get us to simplify our pipeline definitions as it gives us one step to configure instead of 3 and hence only one golang version needs to be specified and this can be moved to branch.cfg


Changes/PRs to be filed to close this story

  • MCM
  • MCM-provider-extensions
    • AWS
    • Azure
    • GCP
    • Openstack - Already done
    • Alicloud
@aaronfern aaronfern added the kind/enhancement Enhancement, improvement, extension label Jul 12, 2024
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Jul 12, 2024
@gardener-robot
Copy link

@aaronfern Label area/todo does not exist.

@aaronfern aaronfern added the area/ops-productivity Operator productivity related (how to improve operations) label Jul 12, 2024
@aaronfern aaronfern assigned aaronfern and unassigned aaronfern Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

2 participants