Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Integration Test to cover all special cases of cascade delete of resources for VM deletion. #904

Open
elankath opened this issue Apr 12, 2024 · 2 comments
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@elankath
Copy link
Contributor

How to categorize this issue?

/area testing
/kind enhancement
/priority 3

What would you like to be added:
We had a bug in the DeleteMachine implementation in Azure where cascade delete option was set for all resources attached to the VM. It should be set only for the resources that were created as a part of VM creation. Ideally, an Integration Test should have caught this.

Why is this needed:
See gardener/machine-controller-manager-provider-azure#142

@elankath elankath added the kind/enhancement Enhancement, improvement, extension label Apr 12, 2024
@gardener-robot gardener-robot added area/testing Testing related priority/3 Priority (lower number equals higher priority) labels Apr 12, 2024
@rishabh-11
Copy link
Contributor

rishabh-11 commented Apr 12, 2024

On thinking more about this, we have another problem here. The IT that we have are not provider-specific. It makes it very difficult to add a test for this case

@elankath
Copy link
Contributor Author

We just need an extension of the Driver interface say DriverTest that provides an additional methods we want for IT's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants