Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all make commands in container. #4

Open
rfranzke opened this issue Feb 4, 2020 · 0 comments
Open

Run all make commands in container. #4

rfranzke opened this issue Feb 4, 2020 · 0 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@rfranzke
Copy link
Member

rfranzke commented Feb 4, 2020

From https://github.com/gardener/gardener-extensions/issues/122

All make commands require various dev resources to be available:

  • golang
  • helm
  • various gnu utils such as tar, gzip, tr, base64, cut, find, grep, xargs.
  • gingo
  • linters.

I think that the most reasonable way to get reproducible builds and things such as make generate is to run those commands in a pre-build container image.
@rfranzke rfranzke added the kind/enhancement Enhancement, improvement, extension label Feb 4, 2020
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 5, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfranzke @gardener-robot