Fix project switch on create cluster page #2047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reset namespace if navigation failed
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
size/xs
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
holgerkoser
reviewed
Sep 27, 2024
| @@ -52,6 +54,10 @@ export function createRouter () { | |||
| } else { | |||
| logger.info('Navigation failure: %s', failure) | |||
| } | |||
|
|
|||
| // Reset namespace if navigation failed | |||
There was a problem hiding this comment.
The rules should be updated only after successful navigation. To me this looks like a hack. I will try to find a better solution soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #923
Special notes for your reviewer:
Release note: