-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud providers via configuration #1553
Open
grolu
wants to merge
36
commits into
master
Choose a base branch
from
enh/configure_cloudprovider_vue3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Sep 11, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 11, 2023
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 11, 2023
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 11, 2023
This was referenced Sep 11, 2023
@grolu You need rebase this pull request with latest master branch. Please check. |
# Conflicts: # frontend/src/components/ShootWorkers/GManageWorkers.vue # frontend/src/views/GNewShoot.vue
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 9, 2023
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 20, 2023
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 20, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 23, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 23, 2024
# Conflicts: # backend/test/acceptance/__snapshots__/api.cloudprofiles.spec.js.snap # charts/gardener-dashboard/charts/runtime/templates/dashboard/deployment.yaml # docs/README.md # frontend/src/components/GCloudProfile.vue # frontend/src/components/NewShoot/GNewShootInfrastructureDetails.vue # frontend/src/components/NewShoot/GNewShootSelectInfrastructure.vue # frontend/src/components/Secrets/GSecretDialogAlicloud.vue # frontend/src/components/Secrets/GSecretDialogAws.vue # frontend/src/components/Secrets/GSecretDialogAzure.vue # frontend/src/components/Secrets/GSecretDialogCloudflare.vue # frontend/src/components/Secrets/GSecretDialogGeneric.vue # frontend/src/components/Secrets/GSecretDialogHCloud.vue # frontend/src/components/Secrets/GSecretDialogInfoblox.vue # frontend/src/components/Secrets/GSecretDialogMetal.vue # frontend/src/components/Secrets/GSecretDialogNetlify.vue # frontend/src/components/Secrets/GSecretDialogVSphere.vue # frontend/src/components/ShootWorkers/GManageWorkers.vue # frontend/src/components/ShootWorkers/GWorkerConfiguration.vue # frontend/src/store/cloudProfile/index.js # frontend/src/store/config.js # frontend/src/utils/shoot.js # frontend/src/views/GNewShoot.vue
grolu
force-pushed
the
enh/configure_cloudprovider_vue3
branch
from
July 23, 2024 13:08
1203a2c
to
bbca10c
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 23, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 23, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 23, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 23, 2024
# Conflicts: # frontend/src/composables/useShootContext.js
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 24, 2024
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 25, 2024
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 6, 2024
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 9, 2024
grolu
changed the title
[DRAFT] Add cloud providers via configuration
Add cloud providers via configuration
Aug 12, 2024
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 12, 2024
# Conflicts: # frontend/src/composables/useShootContext.js
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ipcei
IPCEI (Important Project of Common European Interest)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/rebase
Needs git rebase
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
On top of PR #1434 this PR adds logic to define additional cloud providers via configuration (
customCloudProviders
).It is possible to define a custom secret dialog including (simple) validation and help texts.
It is also possible to configure custom input fields that are added to the
Infrastructure Details
section of the create cluster page.Supported input types:
text
: Simple plain text input.password
: Hidden plain text input.select
: List of values that the user can select.select-multiple
: Allow to select multiple values from a list.json
: Object data in JSON format.yaml
: Object data in YAML input.Supported validations:
required
requiredIf
(ref to other field)regex
isValidObject
(depends on the type - valid json or a yaml object)See example configuration below for more details.
A custom cloud provider icon can be defined using an image resource mounted via asset configuration.
This way it is also possible to overwrite icons as well as names for build-in cloud providers (like aws, gpc, etc) and for machine image vendors (ubuntu, gardenlinux, etc.)
It is possible to provide additional required static data for the shoot template of a custom cloud provider via configuration.
For additional required configurable data, input fields for the custom cloud provider can be defined that will appear on the create cluster page.
This PR also adds a configuration option for the available cloud providers (
cloudProviderList
). This allows to add additional cloud providers as well as configure their order in the Dashboard. It is possible to add cloud providers without additional configuration, the secret dialog and logo will fallback to generic input / icon.This PR removes the logic that filters cloud profiles without a matching seed in the backend. All cloud profiles show up in the frontend. Cloud profiles without matching seed will show a hint to the user.
Example dashboard configuration for a cloud provider with name
custom
Icons can be provided as base64 encoded values when using the helm chart in the frontendConfig.vendorAssets map. Those icons can then be refrenced in the vendor configurations as well as the help html as shown above.
You can also use data: scheme for development. For production it is recommended to provide static assets.
Cloud provider
custom
rendered in the DashboardWhich issue(s) this PR fixes:
Fixes #1445 Fixes #554 Fixes #1707 Fixes #207
Special notes for your reviewer:
Release note: