Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to upstream mcm provider or sync w/ upstream release cycle? #89

Closed
jsravn opened this issue Jun 21, 2021 · 2 comments
Closed

Plans to upstream mcm provider or sync w/ upstream release cycle? #89

jsravn opened this issue Jun 21, 2021 · 2 comments
Labels
area/ops-productivity Operator productivity related (how to improve operations) effort/1d Effort for issue is around 1 day kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/2 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Milestone

Comments

@jsravn
Copy link

jsravn commented Jun 21, 2021

What would you like to be added:

Upstream CA only promises compatibility with the matching kubernetes version. E.g. cluster-autoscaler 1.20 is expected to be run with Kubernetes 1.20. This is mostly so the scheduling decisions match between the k8s scheduler and CA.

This fork doesn't make the distinction, so it's not clear what version of k8s it is compatible with.

I wonder if there are any plans to remedy this. I was thinking either by upstreaming the mcm provider into CA, or by following the same branch process of upstream.

Why is this needed:

So we don't run into issues using incompatible CA versions.

@jsravn jsravn added the kind/enhancement Enhancement, improvement, extension label Jun 21, 2021
@prashanth26
Copy link

prashanth26 commented Jul 21, 2021

Hi @jsravn .

I think you have a fair point. We will try to tabulate the compatibility support as in the upstream CA releases. We plan to update the CA very soon and once we do this we will try to tabulate these supports.

I wonder if there are any plans to remedy this. I was thinking either by upstreaming the mcm provider into CA, or by following the same branch process of upstream.

We have discused this internally in the past, however haven't got to it due to some feature compatibility issues like scale to/from zero suppport etc. But yes, ideally we would like to use the upstream branch as well. Refer - #32.

@prashanth26 prashanth26 added priority/2 Priority (lower number equals higher priority) effort/1d Effort for issue is around 1 day area/ops-productivity Operator productivity related (how to improve operations) labels Jul 21, 2021
@prashanth26 prashanth26 added this to the 2021-Q3 milestone Jul 21, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 18, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 17, 2022
@himanshu-kun
Copy link

/close
We now maintain a release matrix to address the issue -> https://github.com/gardener/autoscaler/tree/machine-controller-manager-provider/cluster-autoscaler#releases-gardenerautoscaler

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ops-productivity Operator productivity related (how to improve operations) effort/1d Effort for issue is around 1 day kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/2 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

4 participants