Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action should fail if no documentation is compiled #9

Open
wilfwilson opened this issue May 20, 2021 · 2 comments
Open

This action should fail if no documentation is compiled #9

wilfwilson opened this issue May 20, 2021 · 2 comments

Comments

@wilfwilson
Copy link
Contributor

wilfwilson commented May 20, 2021

Currently (see e.g. gap-packages/sgpdec#21) this action can silently pass even if it's not actually compiling any documentation.

I'm not sure how to do this.

I guess we would want to look for the existence of the generated files. But they could have different names/be in different places for different files.

Perhaps we could count the number of HTML files found by find in the package, and then after attempting to compile the manual, checking whether that number has increased? A bit hacky.

Is there some generated documentation file that all packages have, in the same place? Ah! We could look at the PackageInfo.g file for the PackageDoc.{HTMLStart,PDFFile,SixFile} component!

@stertooy
Copy link
Contributor

I'm not sure if this is an acceptable or sufficient solution, but one can add the "if-no-files-found: error" flag to the upload-artifact action (example).

@wilfwilson
Copy link
Contributor Author

Thank you for the suggestion.

Yes, it is probably a sufficient solution, but it would unfortunately require changing the Workflow file of every package that uses this build-pkg-docs action, and the point of this action is to avoid having to make such changes to all packages 😉. But for now we could at least add this flag to the example package's workflow file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants