From 894ad13e700ed97befb1f6afbc5121bc59cb6c14 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 31 Oct 2022 23:31:22 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- tpdn/unsuptree_modeler.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/tpdn/unsuptree_modeler.py b/tpdn/unsuptree_modeler.py index 4b52c4c..8d53616 100644 --- a/tpdn/unsuptree_modeler.py +++ b/tpdn/unsuptree_modeler.py @@ -499,7 +499,26 @@ def from_pretrained(cls, pretrained_model_name, state_dict=None, cache_dir=None, logger.info("extracting archive file {} to temp dir {}".format( resolved_archive_file, tempdir)) with tarfile.open(resolved_archive_file, 'r:gz') as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, tempdir) serialization_dir = tempdir # Load config config_file = os.path.join(serialization_dir, CONFIG_NAME)