Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WARNINGS] Theme check for Wordpress.org #430

Closed
codeclinic opened this issue Aug 13, 2020 · 1 comment
Closed

[WARNINGS] Theme check for Wordpress.org #430

codeclinic opened this issue Aug 13, 2020 · 1 comment

Comments

@codeclinic
Copy link

codeclinic commented Aug 13, 2020

I'm trying to upload my theme on WordPress.org/themes repository and I have to make the control of the theme with Theme Check plugin, I had these warnings:

WARNING: fwrite was found in the file assets/titan-framework/inc/scssphp/scss.inc.php File operations should use the WP_Filesystem methods instead of direct PHP filesystem calls.
Line 640: fwrite(STDERR, 'Line $line DEBUG: $value\n');

WARNING: file_put_contents was found in the file assets/titan-framework/inc/scssphp/scss.inc.php File operations should use the WP_Filesystem methods instead of direct PHP filesystem calls.
Line 3662: file_put_contents($out, $css);
Line 3663: file_put_contents($this->importsCacheName($out),

WARNING: file_get_contents was found in the file assets/titan-framework/inc/scssphp/scss.inc.php File operations should use the WP_Filesystem methods instead of direct PHP filesystem calls.
Line 1301: $code = file_get_contents($path);
Line 3640: $imports = unserialize(file_get_contents($icache));
Line 3657: $css = $this->scss->compile(file_get_contents($in), $in);
Line 3685: echo file_get_contents($output);

Ref: #376

@codeclinic
Copy link
Author

This is all inside the SCSS library which wasn't modified and just included. You could technically rewrite those lines in the library ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant