Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.1] Fix alert handling in workflow label handler #18836

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[24.1] Fix alert handling in workflow label handler #18836

merged 1 commit into from
Sep 18, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Sep 17, 2024 •
edited
Loading

Fixes #18801. The label input field is already a standalone input element, there are no structural issues. This issue was likely caused while switching to TypeScript.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Sep 17, 2024
@guerler guerler marked this pull request as ready for review September 17, 2024 15:44
mvdbeek
mvdbeek approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final thing, can you target 24.1 ?

@guerler guerler changed the base branch from dev to release_24.1 September 17, 2024 16:16
@guerler guerler changed the base branch from release_24.1 to dev September 17, 2024 16:16
@guerler guerler changed the base branch from dev to release_24.1 September 17, 2024 16:19
@guerler guerler changed the title Fix alert handling in workflow label handler [24.1] Fix alert handling in workflow label handler Sep 17, 2024
@dannon dannon merged commit 8a35bfc into galaxyproject:release_24.1 Sep 18, 2024
27 checks passed
@itisAliRH itisAliRH deleted the workflow_labels branch September 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.

Workflow Editor required inputs should remove warning indicator when populated
3 participants
@guerler @mvdbeek @dannon