Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the parameter of a conditional always as select #18759

Open
bernt-matthias opened this issue Sep 3, 2024 · 1 comment
Open

Render the parameter of a conditional always as select #18759

bernt-matthias opened this issue Sep 3, 2024 · 1 comment
Assignees

Comments

@bernt-matthias
Copy link
Contributor

For a long time we have a linter role and IUC guideline that requires tool authors to make the conditional parameter a select (ie. forbid boolean select parameters).

Changing these parameters from bool to select requires downstream changes (workflows).

It might be better to just render boolean conditional paramaters as select even if the tool form specifies it as boolean.

@dannon
Copy link
Member

dannon commented Sep 3, 2024

Discussed in dev meeting -- we would like to push back to the IUC with this to understand why this is a requirement. Potentially reduce the lint from warning to info if this isn't actually critical to adhere to.

Need to understand if this is more of a galaxy-side UI standardization request or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage/Discuss
Development

No branches or pull requests

2 participants