Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for subsampling in the random walk nodeOperator classes #518

Open
abensonca opened this issue Jan 2, 2024 · 0 comments
Open

Account for subsampling in the random walk nodeOperator classes #518

abensonca opened this issue Jan 2, 2024 · 0 comments

Comments

@abensonca
Copy link
Collaborator

In nodeOperatorHaloAngularMomentumVitvitska2002, darkMatterProfileScaleRadiusJohnson2021, and nodeOperatorHaloAxisRatiosMenkerBenson2022 we do not account for possible subsampling of halos. It should be possible to include the subsampling weights into the calculation. In principle we should then also account for these when computing the unresolved mass accretion - although this could lead to negative unresolved mass (which is maybe ok numerically?).

It would also be good to set up correct calibration of the subresolution behavior to ensure converged results. This could be done by requiring internal self-consistency - i.e. the distributions of concentration, spin, shape, etc. should not change as the resolution of altered. (This could be checked with/without subsampling.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant