-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement efficient tree filtering for multiple constraints #447
Comments
For example, a case where we want to condition a MW tree to have both an LMC and an SMC. The probability of both will be very small. But, an approach something like this might work:
In this way we build only just as much of the tree as needed before applying our filters. This should be much faster as it allows us to rapidly reject unacceptable trees. Note on statistics: If we do step 5b then we have to be careful about the statistics. By repeatedly growing parts of the tree until we get an SMC match we are biasing the results (potentially). Suppose we allow a range of LMC masses. Higher mass LMCs might be more likely to have an SMC than lower mass LMCs. But, in 5b we just keep growing branches until we get an SMC - so every mass LMC is equally likely to get an SMC. To account for this we would need to weight each tree by |
This would need some new |
We would also need a |
Also, in the |
When using the filtering approach to generating constrained merger trees, the process will become extremely inefficient (i.e. almost all trees will be rejected) as the number of constraints grows. Find ways to improve the efficiency.
The text was updated successfully, but these errors were encountered: