Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keep-alive support #3

Open
gajus opened this issue Apr 26, 2019 · 2 comments
Open

Add keep-alive support #3

gajus opened this issue Apr 26, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gajus
Copy link
Owner

gajus commented Apr 26, 2019

No description provided.

@gajus gajus added enhancement New feature or request help wanted Extra attention is needed labels Apr 26, 2019
@gajus
Copy link
Owner Author

gajus commented Apr 27, 2019

Refer to this issue for supporting information.

https://www.reddit.com/r/node/comments/bhj53t/global_httphttps_proxy_for_nodejs_v12/

@jolivaSan
Copy link

Hi @gajus,

So I understand that 'global-agent' will use keepAlive: 'false' even if we are using a custom instance of an Agent, right? So in the case that you mention in the documentation

This behaviour allows to intercept requests of libraries that use a custom instance of an agent per default (e.g. Stripe SDK uses an http(s).globalAgent instance pre-configured with keepAlive: true).

Even if the Stripe SDK is setting up the keepAlive: true global-agent is changing to keepAlive: 'false' right?

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gajus @jolivaSan