Skip to content

Support all kinds of refs, not just branches and tags #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattwynne opened this issue Mar 10, 2021 · 2 comments
Closed

Support all kinds of refs, not just branches and tags #82

mattwynne opened this issue Mar 10, 2021 · 2 comments

Comments

@mattwynne
Copy link

mattwynne commented Mar 10, 2021

We had a need to be able to push arbitrary refs, not just branches and tags. (See SmartBear/git-en-boite#217 (comment))

I made this hack to get it to work for us:
SmartBear@2dceb3b

However, I'm sure this will have broken something, as I can see assumptions in the code where it expects the ref to either be a branch or a tag. Fortunately it doesn't seem to have broken anything we were relying on in our own test suite.

Are you interested in merging this change in? I'd prefer to only be using our own fork temporarily.

If so, can you coach me how to add tests for it, and with any other changes that might be needed to make it work without breaking the existing API?

@gabrielcsapo
Copy link
Owner

gabrielcsapo commented Mar 10, 2021 via email

@mattwynne
Copy link
Author

OK cool!

I made the PR #83, so let's move the discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants