You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, I'm sure this will have broken something, as I can see assumptions in the code where it expects the ref to either be a branch or a tag. Fortunately it doesn't seem to have broken anything we were relying on in our own test suite.
Are you interested in merging this change in? I'd prefer to only be using our own fork temporarily.
If so, can you coach me how to add tests for it, and with any other changes that might be needed to make it work without breaking the existing API?
The text was updated successfully, but these errors were encountered:
On Wed, Mar 10, 2021 at 12:33 PM Matt Wynne ***@***.***> wrote:
We had a need to be able to push arbitrary refs, not just branches and
tags. (See SmartBear/git-en-boite#217 (comment)
<SmartBear/git-en-boite#217 (comment)>
)
I made this hack to get it to work for us:
***@***.***
<SmartBear@2dceb3b>
However, I'm sure this will have broken something, as I can see
assumptions in the code where it expects the ref to either be a branch or a
tag.
Are you interested in merging this change in? I'd prefer to only be using
our own fork temporarily.
If so, can you coach me how to add tests for it, and with any other
changes that might be needed to make it work without breaking the existing
API?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#82>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOE2WYU63REYQV7KUKR7BLTC7CP7ANCNFSM4Y62MYTA>
.
We had a need to be able to push arbitrary refs, not just branches and tags. (See SmartBear/git-en-boite#217 (comment))
I made this hack to get it to work for us:
SmartBear@2dceb3b
However, I'm sure this will have broken something, as I can see assumptions in the code where it expects the ref to either be a branch or a tag. Fortunately it doesn't seem to have broken anything we were relying on in our own test suite.
Are you interested in merging this change in? I'd prefer to only be using our own fork temporarily.
If so, can you coach me how to add tests for it, and with any other changes that might be needed to make it work without breaking the existing API?
The text was updated successfully, but these errors were encountered: