Conflicting filteringTerms definition in genomicVariations

[mbaudis]

While for other entities in the filteringTerms.yaml/json files no values are provided, in .../genomicVariations filteringTerms.yaml there is an odd entry for 2 alphanumeric filters:

filteringTerms:
  - ftType: alphanumeric
    id: gene
  - ftType: alphanumeric
    id: aminoacidChanges

This is very problematic and misleading since:

• both "filters" have dedicated and documented query parameters (geneId and aminoacidChange)
• the definition of filtering terms here is exceptional and in contrast to the common use (leave the filter definition to implementations)
• a definition here could be perceived as "only those values are permitted"

Proposal Remove in hot fix to avoid further confusion.

[gsfk]

+1 for this.

I also see non-empty filteringTerms.yaml files for cohorts and datasets. They're not as bad as this one, but it's not clear what they're for.

[zykonda]

+1 for this, cohorts and datasets.
Both gene and aminoacidChanges in filtering terms look like code refactoring left over.