-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slf4j-api 2.0.0-alpha1 - not working #45
Comments
Either the 2.0.0 api is different to the 1.8 api, or it is not. |
In any case, it would be great if slf4j-timbre would support the 2.0.0 api. |
Thanks for the report, I'll look into it and also the new API |
thanks @rufoa But after I wrote the ticket I could not repeat that behavior. Very bizarre |
I reproduced it. :-) So I have dependencies whic bring slf4j api 2.0.0. I cannot exclude this dependencies |
Any news on this ? |
Last time I checked (a while ago, admittedly), Ceki was still making breaking changes to the API in slf4j 2.0 alphas. Am I to understand people are actually using it in the wild these days? If so, I should prioritise adding support for it. What was frustrating - a recurring theme with slf4j - is that the 2.0 API isn't actually compatible with the 1.7 API, despite Ceki's claims. I worry that this will necessitate two different versions of slf4j-timbre to be maintained in parallel. Hopefully I find a way to avoid this. |
I see a lot of apps / libraries that use the 2.0 version slf4j api. So it
would be great to be able to pipe their logs to timbre.
I agree tha you will most likely need a different artefact.
…On Sun, May 22, 2022, 20:20 Rufus ***@***.***> wrote:
Last time I checked (a while ago, admittedly), Ceki was still making
breaking changes to the API in slf4j 2.0 alphas. Am I to understand people
are actually using it in the wild these days? If so, I should prioritise
adding support for it.
What was frustrating - a recurring theme with slf4j
<qos-ch/slf4j#190/#issuecomment-495959349> - is
that the 2.0 API isn't actually compatible
<https://jira.qos.ch/browse/SLF4J-495?focusedCommentId=20714&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-20714>
with the 1.7 API, despite Ceki's claims. I worry that this will necessitate
two different versions of slf4j-timbre to be maintained in parallel.
Hopefully I find a way to avoid this.
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACS2CGUC5RRS5JZXVUSC3M3VLLMNFANCNFSM47YVHKEA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The only dependency of mine that uses it is See-also: brettwooldridge/HikariCP#2078 |
@devurandom me too. Not sure if it will cause any error. (finger crossed). |
Now the following also depend on it, not just org.slf4j/log4j-over-slf4j {:mvn/version "2.0.0"}
org.slf4j/jul-to-slf4j {:mvn/version "2.0.0"}
org.slf4j/jcl-over-slf4j {:mvn/version "2.0.0"}
org.slf4j/osgi-over-slf4j {:mvn/version "2.0.0"} |
I'd also appreciate having support for slf4j-api v2.x.x These are my dependencies right now: org.slf4j/jcl-over-slf4j {:mvn/version "2.0.5"}
org.slf4j/jul-to-slf4j {:mvn/version "2.0.5"}
org.slf4j/log4j-over-slf4j {:mvn/version "2.0.5"} and as a workaround I'm overriding the slf4j-api transitive dependency with Happy to help; I can see that the problem is with the binders because they were removed from slf4j-api some time ago (e.g. StaticLoggerBinder) but I'm not sure what's meant to replace it. |
Replaces the SLF4J 1.7.x Binders with an SLF4J 2.x ServiceProvider. Works in example ("integration-test").
A lot of AWS libraries are using v2 now as well. We just noticed several apps in production stopped logging and looks like it was related to the upgrade to v2 of slf4j-api. |
clojure -X:deps tree
log output in app
The text was updated successfully, but these errors were encountered: