Fix custom abilities breaking char sheet, and fix ability roll label to be non-translated so it uses the right data.

Author: mcglincy

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 4.0.5
+
+- Additional fixes for abilities/languages.
+
 # 4.0.4
 
 - Fix food roll in scvmfactory.

module/actor/sheet/character-sheet.js

@@ -63,8 +63,9 @@ export class MBCharacterSheet extends MBActorSheet {
     if (additionalAbilitiesCsv) {
       const customAbilities = additionalAbilitiesCsv.split(",").map((key) => {
         return {
+          name: key,
+          label: key, // currently, custom abilities aren't localized 
           value: data.system.abilities[key.toLowerCase()]?.value ?? 0,
-          label: key,
         };
       });
       if (customAbilities.length) {

module/handlebars.js

@@ -35,11 +35,11 @@ export function configureHandlebars() {
     return result;
   });
   Handlebars.registerHelper("abilityLabelClass", function (string) {
-    string = string.label;
-    if (!["Agility", "Presence", "Strength", "Toughness"].includes(string)) {
-      return "custom " + string.toLowerCase();
+    string = string.toLowerCase();
+    if (!["agility", "presence", "strength", "toughness"].includes(string)) {
+      return "custom " + string;
     }
-    return string.toLowerCase();
+    return string;
   });
   Handlebars.registerHelper("inputName", function (string) {
     return "system.abilities." + string.toLowerCase() + ".value";

templates/actor/character/sheet-header.hbs

@@ -130,7 +130,7 @@
         data-dtype="Number"
         size="3"
       />
-      <span class="ability-label rollable {{abilityLabelClass this}}">{{abbreviate this.label}}</span>
+      <span class="ability-label rollable {{abilityLabelClass this.name}}">{{abbreviate this.label}}</span>
     </div>
     {{/each}}
   </div>