New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and refactor codebase #9

Open

3 tasks done

dymurray opened this issue Mar 26, 2019 · 4 comments

Contributor

dymurray commented Mar 26, 2019 •

edited by alexander-demicev

Loading

There are many instances of duplicated code across backup/restore in the same package that can be cleaned up. An example:
https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/common/backup.go#L49
https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/common/restore.go#L49
A lot of backup code is doing nothing... would be good to go through and delete whatever we are not using:
https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/route/backup.go
https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/buildconfig/backup.go
Remove all copyrights that refer to heptio's contributors

alexander-demicev self-assigned this

alexander-demicev commented Mar 27, 2019 •

edited

Loading

I will take this issue

alexander-demicev commented Mar 27, 2019 •

edited

Loading

#12 - Removed copyrights

alexander-demicev commented Mar 29, 2019

#19 - Removed unused code

alexander-demicev commented Apr 2, 2019

alexander-demicev removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment