Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opacity management in actor.sphere #352

Open
skoudoro opened this issue Jan 6, 2021 · 1 comment
Open

Update opacity management in actor.sphere #352

skoudoro opened this issue Jan 6, 2021 · 1 comment

Comments

@skoudoro
Copy link
Contributor

skoudoro commented Jan 6, 2021

After looking more in detail into your fix, I think we should avoid using actor.GetProperty().SetOpacity(opacity). It seems not compatible with our architecture.
Ideally, in the function actor.sphere, we would check if opacity != 1. if yes, we should update the color array by adding a dimension if it is an Nx3, or by updating the last dimension if it is an Nx4.

I will merge your PR because it fixes the actor.point but we need a new PR to improve this version.

Originally posted by @skoudoro in #351 (comment)

@skoudoro skoudoro added this to the v0.7.0 milestone Jan 6, 2021
tantheta01 added a commit to tantheta01/fury that referenced this issue Jan 20, 2021
@tantheta01
Copy link

I have generated a PR for this issue. Thank you.

tantheta01 added a commit to tantheta01/fury that referenced this issue Jan 27, 2021
@skoudoro skoudoro modified the milestones: v0.7.0, v0.8.0 Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants