Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots with image placement examples do not use the template #17

Open
alfredocambera opened this issue Nov 26, 2019 · 4 comments
Open

Comments

@alfredocambera
Copy link

Reference images are confusing as they do not use hugo-kiera

@funkydan2
Copy link
Owner

I don't understand. The images [in the readme]https://github.com/funkydan2/hugo-kiera#images) look like screenshots of Kiera to me (you can see the raw files here.

And if you build the example site by running hugo server --theme="../.." from the exampleSite directory, you can see how these shortcodes work using 'filler' images.

@alfredocambera
Copy link
Author

They don't look the same to me. Maybe is a thing of my monitor but the headings font looks different https://imgur.com/a/Z02TeOC

Could you please give me your opinion?

@funkydan2
Copy link
Owner

Yep, you're probably right. If you look at the history of the CSS file, the base font was changed in November 2017, and screenshots are older than that.

If you're able to redo the screenshots (probably not with the blank images as the example site does...but something nice like what's currently there) and submit a PR, I'll merge.

@alfredocambera
Copy link
Author

Sure, I'll do it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants