Unstable special rules #358
Comments
spirillen
added a commit
to foreign-affairs/PyFunceble-docs
that referenced
this issue
Mar 11, 2024
While working with funilrys#358, funilrys#354 & https://github.com/mitchellkrogza/Phishing.Database/issues/840 I found that the hosting company also uses the HTTP code 428 for disabled (Website is archived.) Example URI ```css http://httpmwankaiwqkcom.000webhostapp.com/ http://https244577889078564546464534353date.000webhostapp.com/ ```
funilrys
pushed a commit
that referenced
this issue
Mar 26, 2024
While working with #358, #354 & https://github.com/mitchellkrogza/Phishing.Database/issues/840 I found that the hosting company also uses the HTTP code 428 for disabled (Website is archived.) Example URI ```css http://httpmwankaiwqkcom.000webhostapp.com/ http://https244577889078564546464534353date.000webhostapp.com/ ```
funilrys
added a commit
that referenced
this issue
Mar 26, 2024
This patch touches #358. Indeed, before this patch, the special rules may have been unstable when testing domains (not URL). This patch fixes the issue by ensuring that our http_status_code lookup is always done against a URL - if the testeted subject is not an http(s) URL. Contributors: * @spirillen
|
For those who are not into Python.
cc: @spirillen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I was reporting to @mitchellkrogza in https://github.com/mitchellkrogza/Phishing.Database/issues/840 it comes to my attention that the special rules are inconsequential in the test result.
IE: these two are by visiting the domains HTTP 410, which should have been switched to down by rule, but are marked ACTIVE
PyFunceble/PyFunceble/checker/availability/extras/rules.py
Line 80 in 73e7fe5
The text was updated successfully, but these errors were encountered: