Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health for integrity verification should take into account oldest verification (instead of newest) #245

Open
joonas-fi opened this issue Jun 5, 2024 · 1 comment
Open

Health for integrity verification should take into account oldest verification (instead of newest) #245

joonas-fi opened this issue Jun 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@joonas-fi
Copy link
Member

varasto/pkg/stoserver/stohealth/ivchecker.go

Line 45 in ea0be71

since := time.Since(newest)

This should be changed to oldest

Rationale: search for weakest link instead of strongest.
@joonas-fi joonas-fi added the enhancement New feature or request label Jun 5, 2024
@joonas-fi
Copy link
Member Author

Seems the limitation was a conscious design choice:

varasto/pkg/stoserver/stohealth/ivchecker.go

Lines 22 to 23 in ea0be71

// TODO: this check only checks the latest completed check, and trusts the user having
// ran it for each applicable volume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joonas-fi