Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About skipping label 0 when constructing dataset #6

Open
XBR-1111 opened this issue Dec 1, 2021 · 1 comment
Open

About skipping label 0 when constructing dataset #6

XBR-1111 opened this issue Dec 1, 2021 · 1 comment

Comments

@XBR-1111
Copy link

XBR-1111 commented Dec 1, 2021

Firstly, thank you for sharing your code and data.
However, when loading data, the code just skips samples with label 0, whose next-day return is between -0.5% and 0.55%. It's not good especially for test set. For unknown data in test set, It actually have 3 labels, and the code destroys the distribution of test data.
I just wonder whether my understand is correct.

@fulifeng
Copy link
Owner

fulifeng commented Jan 5, 2022

Yes, this is not a good way to construct label. But this is a hard choice. During my rejected submission, there are comments like "Should follow the same setting as previous work (StockNet)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants