Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work, shopify API now requires version to be set explicitly #4

Open
fzembow opened this issue Aug 6, 2019 · 4 comments
Open

Comments

@fzembow
Copy link

fzembow commented Aug 6, 2019

When trying to authenticate, you get shopify.api_version.VersionNotFoundError. This is because it seems Shopify now requires that an API version number be set explicitly in the Session, see: https://github.com/Shopify/shopify_python_api#-breaking-change-notice-for-version-500-

@zinyosrim
Copy link

The readme has information on this

@Anmol-Gulati
Copy link
Collaborator

Contributions and updates to repo are welcome. Happy to review 🙂

@fzembow
Copy link
Author

fzembow commented Aug 6, 2019

@Anmol-Gulati see #5

@zinyosrim not sure what information you're referring to (README doesn't say anything about shopify versions), updated documentation in my PR though

@daniel-gomes
Copy link

@fzembow thanks for the fix, however, I needed to do some changes to get the shopify_login_required()decorator working since the Shopify Version was still missing in some places, I PR'ed it to your PR: formsort#1 . Have a look and let me know, would be great to get these 2 PRs merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants