Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch-job should print the logs if the job has succeeded before calling #7

Open
nh13 opened this issue Jun 5, 2020 · 0 comments
Open

watch-job should print the logs if the job has succeeded before calling #7

nh13 opened this issue Jun 5, 2020 · 0 comments
Assignees
@nh13

Comments

@nh13
Copy link
Member

nh13 commented Jun 5, 2020

Currently, there's a race condition between the background thread printing the logs and the main thread waiting on status.
nh13 added a commit that referenced this issue Jun 6, 2020
@nh13
Improvements to watching Batch jobs
6fa07e5 
- refactor batch.Status to store which statuses have CloudWatch logs.
  This introduces a backwards compatible API change.
- watch_job does not skip over cloud logs (#7)
- better handling of exceptions while print logs while watching a batch job
- bumping minor version as we have backwards incompatible change
@nh13 nh13 mentioned this issue Jun 6, 2020
Merged
@nh13 nh13 self-assigned this Jun 6, 2020
nh13 added a commit that referenced this issue Jun 10, 2020
@nh13 @sstadick
Improvements to watching Batch jobs (#11)
7f8132b 
* Improvements to watching Batch jobs

- refactor batch.Status to store which statuses have CloudWatch logs.
  This introduces a backwards compatible API change.
- watch_job does not skip over cloud logs (#7)
- better handling of exceptions while print logs while watching a batch job
- bumping minor version as we have backwards incompatible change

Co-authored-by: Seth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nh13 nh13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nh13