Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a way to view the logs that bwa emits #41

Open
clintval opened this issue Sep 23, 2024 · 1 comment
Open

There should be a way to view the logs that bwa emits #41

clintval opened this issue Sep 23, 2024 · 1 comment

Comments

@clintval
Copy link
Member

Interaction with BWA is implemented using ExecutableRunner.

By default, all IO channels are set to PIPE:

stdin: int = subprocess.PIPE,
stdout: int = subprocess.PIPE,
stderr: int = subprocess.PIPE,

BWA doesn't override any of them.

super().__init__(command=command)

To interact with the PIPEs BWA will read and write to the private subprocess:

self._subprocess.stdin.write(fastq_str)

self._reader = sam.reader(path=self._subprocess.stdout, file_type=sam.SamFileType.SAM)

I think there is a small memory use bug here in that stderr will be written to a pipe that will never be read from. A buffer may be created and only increase in size. Regardless, I think that stderr should be redirected to a logging stream (perhaps with DEBUG level) so that a user has a way of reading them.

Originally raised in: #32 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants