Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to source for individual methods on Github #7

Open
tgriesser opened this issue Apr 9, 2012 · 8 comments
Open

Linking to source for individual methods on Github #7

tgriesser opened this issue Apr 9, 2012 · 8 comments

Comments

@tgriesser
Copy link

Thought it'd be cool if clicking on items in the class reference would bring someone to the Github source line for that method...

For example clicking on the "get" method in Fuel -> Arr would bring you to https://github.com/fuel/core/blob/1.1/develop/classes/arr.php#L34

@frankdejonge
Copy link
Contributor

This would be unmanageable. Whenever a file changes all the link would have to update. There will be a link to the corresponding method doc, that will be enough to work with in our opinion.

@WanWizard
Copy link
Member

Actually, it's not that bad. ;)

That line number is actually part of the Docblox XML, so I can add it to the parse process...

it might be a challenge to map it to the correct github link, as we don't document the invididual repo's, but only the assembled FuelPHP installation. So paths will not match...

@WanWizard WanWizard reopened this Apr 9, 2012
@frankdejonge
Copy link
Contributor

@WanWizard but that would mean a post-deploy docs buildup from the group on up on every commit, you sure you want this?

@WanWizard
Copy link
Member

this is not about docs, it's about the api docs.

The docblox XML is currently generated every hour for every version of FuelPHP, and every 15 minutes for the current version. The XML is pre-processed by a task in the background, pages are only generated when requested (and cached after generation (still a todo)).

@frankdejonge
Copy link
Contributor

@WanWizard just know what you're getting yourself into ;)

@WanWizard
Copy link
Member

It's a feature request, not a commitment. :)

@col-panic
Copy link

Would be really cool - but seems to be stale ... ;)

@WanWizard
Copy link
Member

If by that you mean it doesn't seem to be on my priority list, you might be right... 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants