Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_async file is closed on arrival #853

Open
vttrifonov opened this issue Mar 1, 2024 · 1 comment
Open

open_async file is closed on arrival #853

vttrifonov opened this issue Mar 1, 2024 · 1 comment

Comments

@vttrifonov
Copy link

Not sure if the open_async functionality is ready for release but it returns a file which is closed on arrival.

f = await fs.open_async(path, 'wb')
f.closed --> True

S3AsyncStreamedFile.init never calls it super which takes care of marking the file as "not closed".

@martindurant
Copy link
Member

Please do fix; but you are right that the async files are not done and perhaps should be abandoned. GenericFileSystem does use them, though, since that involves moving bytes between filesystems, so streaming is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants