Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize accessing members on delegate constructors as high-precedence applications #964

Open
5 tasks done
Happypig375 opened this issue Jan 21, 2021 · 1 comment
Open
5 tasks done

Comments

@Happypig375
Copy link
Contributor

Happypig375 commented Jan 21, 2021

type private GetNameDelegate = delegate of Utf8JsonReader -> string
let tokenType = (GetNameDelegate(fun r -> nameof r.TokenType)).Invoke(Utf8JsonReader()) // OK
let tokenType2 = GetNameDelegate(fun r -> nameof r.TokenType).Invoke(Utf8JsonReader()) // FS0001 This expression was expected to have type 'GetNameDelegate' but here has type 'string'

#644 contains a section about High Precedence Application. It is weird for delegate constructors to be excluded from it.

Pros and Cons

The advantages of making this adjustment to F# are

  1. Consistency
  2. Convenience
  3. Conciseness

The disadvantages of making this adjustment to F# are (none)

Extra information

Estimated cost (XS, S, M, L, XL, XXL): XS

Related suggestions: #760 - Delegate constructors cannot be used as normal functions - i.e. cannot be piped into (Also opened by me lol)

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

@dsyme
Copy link
Collaborator

dsyme commented Jan 21, 2021

I'll mark this as approved, it make sense to allow this (though I don't really see why you'd invoke a delegate right after constructing it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants