Adding a new config to dump the incoming requests #101
Conversation
Adding a new configuration option per imposter to dump into the stdout the incoming requests. This configuration could be override by a command line parameter, in which case all the imposter will log to stdout the incoming requested regardless their configuration.
|
@aperezg, Could you please check this PR? Thanks!!! |
There was a problem hiding this comment.
Hey @pafuent, sorry for the late reply. I've been OOO and I think @aperezg will be busy for a few more weeks.
I'd say the code looks quite good. However, I'd like to better understand what you're trying to solve with this approach because we discussed that in the past with @aperezg and we agreed that a (either single -v/--verbose or multiple -v, -vv, -vvv) verbose flag would be really helpful to better understand what's happening under the hood (incoming requests, outgoing responses, imposters matched, etc). Which, as fair as I understood, would cover what you suggested to add here.
So, what do you think about jumping into the issue you created (#100) and comment it? Thanks!! 😄
|
hello @pafuent will you continue with this PR? |
|
Sorry for not taking care of this PR, it fell into the cracks and got forgotten. Seems that #170 is taking care of this, so I will close this PR. |
Adding a new configuration option per imposter to dump into the stdout the incoming requests.
This configuration could be override by a command line parameter, in which case all the imposter will log to stdout the incoming requested regardless their configuration.
Fixes #100