Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to see the incoming requests dump into stdout #100

Open
pafuent opened this issue Jun 8, 2021 · 6 comments
Open

I would like to see the incoming requests dump into stdout #100

pafuent opened this issue Jun 8, 2021 · 6 comments

Comments

@pafuent
Copy link

pafuent commented Jun 8, 2021

I would like to have a way to configure, per imposter, if the incoming requests should be dumped to stdout or not.
Also would be nice to have a command line option to override all imposters dump configurations.

@joanlopez
Copy link
Member

Hey @pafuent, thanks for creating the issue, I think something like this could be really helpful and benefitial for Killgrave users.

So, before diving into code implementations, could you bring a bit more information about what's your specific use case and/or what are you exactly trying to solve by adding this feature?

There's no issue yet, but we discussed adding a verbose (-v/--verbose) configuration option with @aperezg in the past which would basically cover your use case (if I understood it correctly) and bring some additional information to the user. So, I'm wondering whether it does worth to add this feature as a separated option or not.

Thanks!! 🙌🏻

@pafuent
Copy link
Author

pafuent commented Jun 18, 2021

Well the concrete use case that I'm trying to solve is related to logging. I needed to test locally the implementation of a logging proxy that will send the logs that receive to a multiple destinations. One of them is Splunk, so instead of deploying a local instance, I used killgrave to simulate it. But then I needed to validate that some tweaks made to the incoming log were sent properly to Splunk. And in my case, it's far more easy to just grep the output of killgrave than checking that in a full fledged Splunk instance.
As you mention, a verbose flag would solve my use case. I also like the idea of the multiple levels, because in my case the imposters that matched is not valuable, so if I can skip those it will be better.
Let me know if you have a PR already for that, if that isn't the case, I would be glad to implement it in my PR.

@joanlopez
Copy link
Member

Gotcha! Thanks for the explanation! 🙏🏻 Sounds like a really good usage case for Killgrave 🙌🏻

Let me know if you have a PR already for that, if that isn't the case, I would be glad to implement it in my PR.

There's no PR neither an actual design, so feel free to either suggest your idea on the issue (which levels and what information will be logged for each) or to redo the existing pull request in a sense it introduces a basic implementation of the "verbose" flag that could be evolved in the near future.

@pafuent
Copy link
Author

pafuent commented Jun 22, 2021

Sure, I'll try to came up with something and update my PR accordingly.

@pafuent
Copy link
Author

pafuent commented Aug 21, 2024

Sorry for not taking care of this PR, it fell into the cracks and got forgotten. Seems that #170 is taking care of this, so I will close this PR.

@pafuent pafuent closed this as completed Aug 21, 2024
@pafuent
Copy link
Author

pafuent commented Aug 21, 2024

Sorry, I closed the issue not the PR 🤦🏼‍♂️

@pafuent pafuent reopened this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants