Stretch issues on audio and video

[KirbysDarkNebula]

AUDIO: Audio stretch popup doesn't work.

I was checking the code related to stretching and noticed that audio stretching should be working but for some reason clicking on stretch from the right click menu doesn't do anything.
This doesn't seem to be a limitation of the program with stretching audio tracks, but rather of it being unable to start the popup with the given parameters.

The code for it is basically 1:1 to the one used for images/videos (which works perfectly) so I really don't understand what could be the issue:
sound: https://github.com/friction2d/friction/blob/main/src/core/Sound/eindependentsound.cpp#L80-L90
image: https://github.com/friction2d/friction/blob/main/src/core/Boxes/animationbox.cpp#L235-L246

I manually tried adding popup buttons like the delete item one (https://github.com/friction2d/friction/blob/main/src/core/Sound/eindependentsound.cpp#L92-L95) with hardcoded stretch values just to test and the audio did actually change, proving that the problem is calling the input popup.

AUDIO & VIDEO: Stretch property not working on project load.

Both audio and video are able to save the property to the project files, but similarly to #331 they don't get applied on project load. I checked all stretch code and I wasn't able to find when this property is saved to the project file, but after comparing 2 files with different stretches it's clear that the property does get saved.

I wouldn't mind fixing this myself but despite finding the file load and save functions I cannot really seem to find where options like the one from the issue highlighted before (#331) and this one are handled within those functions.

[rodlie]

Note that NLE A/V stuff is not a priority in Friction, it is a fork of something called Enve is Not a Video Editor ;)

Assume stuff I have not touched since forking is broken/never worked.

[rodlie]

Regarding the issue with audio stretch:
https://github.com/friction2d/friction/blob/main/src/core/Sound/eindependentsound.cpp#L83

It probably fails on the dialog so nothing happens

[KirbysDarkNebula]

yup that's the same behavior I found, that's why I'm confused as to why it happens (or rather doesn't happen)

[rodlie]

Will need to debug the issue, might have time later tonight.

[rodlie]

Yeah, found the issue. The usage of the lambda is broken (of course it is 😄 ) https://github.com/friction2d/friction/blob/main/src/core/Sound/eindependentsound.cpp#L80

Will commit a replacement later today (together with a fix for #331)

[rodlie]

So, I pushed a fix for #331 and a fix for the stretch action in the av branch.

But load/save of stretch is not implemented anywhere, so this will need to be added.

[KirbysDarkNebula]

Oh I see you changed the action to a trigger in the end. Works as expected now, nice.

As for the load/save stuff I really thought that the stretch was saved, since I compared files (on a hex editor) where the only changes were the stretch (going from default to 1000), and they did indeed have differences so once again I don't understand when these changes are happening and it really does seem like they are a product of stretch getting saved.

(Maybe the stretch isn't actually getting saved but it's some frame duration property that gets affected by the stretch and DOES get saved?)

[rodlie]

(Maybe the stretch isn't actually getting saved but it's some frame duration property that gets affected by the stretch and DOES get saved?)

Don't know :)

What I do know is that there is no code to load or save the stretch value. Will add support for it, but it will have to wait until tomorrow (probably) as this involves bumping the project format etc (any changes to the file format need proper testing before usage).

[rodlie]

The av branch should now read/write the audio/video stretch state, note project format changes so only test on backup projects.

Will make a PR for this issue and #331 when confirmed ok.

[KirbysDarkNebula]

Just tested the PR and it seems to be working perfectly, stretch gets loaded and saved as expected 👍

[rodlie]

Great, will merge the changes later today.