-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer
: Remove periodic()
and timeout()
#264
Merged
+54
−301
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
841cf87
Fix typo
llucax d17e44e
Remove `Timer.periodic()` and `Timer.timeout()` from tests
llucax 8778f82
Remove `Timer.periodic()` and `Timer.timeout()` from docs
llucax df1c8ff
Make docs more cohesive with `Timer` constructors removal
llucax 2477050
Move and improve note in the quick start section
llucax aef8dd9
Remove `Timer.periodic()` and `Timer.timeout()`
llucax cbccb5c
Update release notes
llucax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove
Timer.periodic()
and Timer.timeout()
from tests
Signed-off-by: Leandro Lucarella <[email protected]>
commit d17e44e2a3df763d8a01fcb1c6321d178fc38caf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think
SkipMissedAndDrift
should be an instance created in the channel package, so that we don't have to specify the()
to create an instance of the thing?This was a bit confusing for me the first time I did this, because I was expecting to pass just the policy, not an object of the policy that I had to create.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The policies can have options, and
SkipMissedAndDrift()
have one (delay_tolerance
). I think if we provide fixed instances with fixed options we'll eventually need another PR to remove them because they are still hiding the complexity :)