Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default page size needs to be exposed to the user or handled internally #127

Open
cyiallou opened this issue Jul 26, 2024 · 1 comment
Open

Default page size needs to be exposed to the user or handled internally #127

cyiallou opened this issue Jul 26, 2024 · 1 comment
Labels
part:client Affects the python client priority:high Address this as soon as possible status:blocked Other issues must be resolved before this can be worked on type:bug Something isn't working type:enhancement New feature or enhancement visitble to users
Milestone
v1.0.0

Comments

@cyiallou
Copy link

What's needed?

When requesting weather data for a number of locations you might get the following error "Error: InvalidPageSize: Page size must be a multiple of the number of locations".

Proposed solution

The client should either handle the page size value internally and based on the number of requested locations or expose the relevant parameter to the user. I think the former would be preferable in my opinion.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@cyiallou cyiallou added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Jul 26, 2024
@TalweSingh TalweSingh added priority:high Address this as soon as possible type:bug Something isn't working part:client Affects the python client and removed part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed part:client Affects the python client labels Jul 26, 2024
@cwasicki cwasicki added this to the v1.0.0 milestone Sep 10, 2024
@TalweSingh
Copy link
Contributor

Only needed if we stick with pagination. Blocked until this is decided.

@TalweSingh TalweSingh added the status:blocked Other issues must be resolved before this can be worked on label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:client Affects the python client priority:high Address this as soon as possible status:blocked Other issues must be resolved before this can be worked on type:bug Something isn't working type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@cyiallou @TalweSingh @cwasicki