-
Notifications
You must be signed in to change notification settings - Fork 20
Move to 6s Blocktimes #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Should we also update the mortality window for signature verification? |
Do we know the intended duration for the following constant?
The comment mentions that the mortality window is meant to be 24 hours, but with a 12-second block time, it actually covers two days. Once we update to 6-second block times, it would match the 1-day duration. Could you clarify the correct intention here — should the mortality window be 1 day or 2 days? |
Yes! The other ones @aramikm is better to answer than I. |
@wilwade For the “Review and update Governance times via migration” task, I went through all the constants to check if any needed updating but couldn't find any that required changes. I also looked into whether any migrations were necessary and didn't find anything there either. Additionally, I checked the Polkadot releases for references to any related migrations but found nothing. I also checked with @shannonwells to see if there was anything she was aware of, but nothing came up. Was there a specific migration you had in mind? |
@enddynayn I do not know of any other particular ones. I did a quick look through the ones I was worried about (like I don't see any other |
@wilwade Got it, I noticed those as well and went through the config parameters. Thanks for taking another look. |
This update reduces block time to 6 seconds. As a result, the Capacity Epoch length has been adjusted to account for the reduced latency. Additionally, the default interval sealing time has been changed to 6 seconds. A migration has also been added to update the StorageVersion of the CollatorSelection pallet. Commands to test the runtime migration: Paseo ``` make try-runtime-create-snapshot-paseo-testnet make try-runtime-use-snapshot-paseo-testnet ``` Mainnet ``` cargo build --features frequency,try-runtime&& \ try-runtime --runtime ./target/release/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://1.rpc.frequency.xyz:443 --pallet Capacity --pallet System ``` Or Paseo ``` cargo build --features frequency,try-runtime && \ try-runtime --runtime ./target/release/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://1.rpc.frequency.xyz:443 --pallet Capacity --pallet System ``` ``` cargo build --features frequency-testnet,try-runtime && \ try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://rpc.testnet.amplica.io:443 -pallet Capacity --pallet ``` <img width="1286" alt="Screenshot 2024-10-07 at 3 13 25 PM" src="https://github.com/user-attachments/assets/045f2bf1-cafc-41a1-b7f6-0baf12795b87"> #1920 #2141 --------- Co-authored-by: enddynayn <[email protected]>
Merged. |
Uh oh!
There was an error while loading. Please reload this page.
When async backing is supported on Polkadot, Frequency can move to a default of 6s block times.
Tasks
MILLISECS_PER_BLOCK
Helpful resources
The text was updated successfully, but these errors were encountered: