e-Link problems

[jnehring]

The CKEditor plugin uses non-existing e-Link templates for "spelling russian" and "spelling japanese". To reproduce the problem:

• Click detect concepts button
• click "get additional info"
• click "spelling russian" or "spelling chinese"

Please add the missing e-Link templates. I post the SQL queries to insert them directly to the database so they get the right IDs:

INSERT INTO `template` (`id`, `visibility`, `description`, `endpoint`, `label`, `query`, `owner_name`, `endpoint_type`, `creation_time`) VALUES 
(4517,1,NULL,'http://data.europa.eu/euodp/sparqlep','jrcnamesquery','PREFIX lemon: <http://www.lemon-model.net/lemon#> PREFIX skos: <http://www.w3.org/2004/02/skos/core#> PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> CONSTRUCT {<@@@entity_uri@@@> lemon:writtenRep ?Rep } WHERE { { SELECT  ?Rep ?ref WHERE   {      ?variant rdf:type lemon:LexicalEntry .     ?variant lemon:language \'ja\' .     ?variant lemon:sense ?sense .     ?sense lemon:reference ?ref .     ?ref <http://www.w3.org/2002/07/owl#sameAs> <@@@entity_uri@@@>.     ?variant lemon:canonicalForm ?form .     ?form lemon:writtenRep ?Rep .   }       } }','admin',0,1476199668967),
(4518,1,NULL,'http://data.europa.eu/euodp/sparqlep','jrcnamesquery','PREFIX lemon: <http://www.lemon-model.net/lemon#> PREFIX skos: <http://www.w3.org/2004/02/skos/core#> PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> CONSTRUCT {<@@@entity_uri@@@> lemon:writtenRep ?Rep } WHERE { { SELECT  ?Rep ?ref WHERE   {      ?variant rdf:type lemon:LexicalEntry .     ?variant lemon:language \'ru\' .     ?variant lemon:sense ?sense .     ?sense lemon:reference ?ref .     ?ref <http://www.w3.org/2002/07/owl#sameAs> <@@@entity_uri@@@>.     ?variant lemon:canonicalForm ?form .     ?form lemon:writtenRep ?Rep .   }       } }','admin',0,1476199820947)

[munnellg]

@jnehring I've just added those entries to our database

[jnehring]

Thank you. But still it does not look right. I cannot see Japanese or Russian spelling. @pheyvaer @ghsnd can you please take a look at whats wrong? https://api.freme-project.eu/ckeditor/ckeditor/samples/freme.html

[bjdmeest]

@jnehring When reviewing #28 , I used the text I know Angela Merkel, and it does seem to work. I assume that the found entities of the default text are not present in the endpoint that contain the japanese and russian spelling, thus no results are returned

[jnehring]

Ah ok now I understand. Do you think it possible to improve this until the review so it looks nicer? It looks like a bug.

[bjdmeest]

d2b0377 fixes this, but because of #32 , someone will need to update the code on https://api.freme-project.eu/ckeditor/ckeditor/samples/freme.html

[jnehring]

Is this commit also merged in the dev version? I updated the API URL of the ckeditor dev version to the live api to test this. When I open the dev version it still it looks like a bug and there are errors on the javascript error console: http://rv1443.1blu.de/ckeditor-dev/ckeditor/samples/freme.html

[bjdmeest]

I merged it in the dev (f078998). I also updated the template ids (549da0d), so for me it now works on http://rv1443.1blu.de/ckeditor-dev/ckeditor/samples/freme.html

[jnehring]

Thank you for the quick implementation. We can copy this to the ADAPT server. @munnellg please download the updated version and replace the existing ckeditor files with the updated files.

[munnellg]

@jnehring I've downloaded and deployed the new version now

[jnehring]

I tried it and it works fine now. I had to clear the browser cache. So this is done.

[jnehring]

@fsasaki mentioned that the Russian and Japanese spelling functionalities are very important for the review. @bjdmeest it looks like you removed the functionality. Can you re-enable it instead of deleting it?

[bjdmeest]

I have re-inserted the russian and japanese in the dev-branch (c228880), with an error message if no results are found. If fine now, I'll merge with the master branch

[jnehring]

Looks good. @fsasaki also confirmed it is good now. @bjdmeest please merge it in the master. @munnellg i updated the zip archive, please install a new live installation. sorry about installing it multiple times, i think this is the final version.

[munnellg]

@jnehring That's done now

[jnehring]

I think something went wrong. When the new feature is enabled you can

1. Click "detect concepts".
2. Click on an annotation, e.g. "Ai Weiwei"
3. Click "get additional info". This opens a window with multiple tabs. There are two tabs "Spelling Japanese" and "Spelling Russian".

On the dev system rv1443.1blu.de the tabs are present. On the live version api.freme-project.eu they are not present.

[munnellg]

That's very strange. Is it possible there is something missing from the zip folder or could it be something else?

[jnehring]

I unzipped the zip archive to a folder "test" and created a new installation:

http://rv1443.1blu.de/test/ckeditor-dev/ckeditor/samples/freme.html

This installation shows the tabs. So I think the zip archive is complete.