Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellcheck linter issues need fixing #321

Open
Noki opened this issue Jul 18, 2022 · 2 comments
Open

shellcheck linter issues need fixing #321

Noki opened this issue Jul 18, 2022 · 2 comments
Milestone
falter-1.3.0

Comments

@Noki
Copy link
Member

Noki commented Jul 18, 2022

There are shellcheck issues in this repo that should be fixed so the shellcheck github action could be merged.
@Noki
Copy link
Member Author

Noki commented Feb 8, 2023

ShellCheck is now part of the workflow. The files listed as ignore in the following commit need fixing: b437c88

The fixes should be send in as pull requests that fix the issues and remove the corresponding line in the workflow.

@Noki Noki added this to the falter-1.3.0 milestone Mar 14, 2023
@Noki
Copy link
Member Author

Noki commented Aug 6, 2023

We switched to superlinter with dec25fb and an approach where we fix linter issues for changed files. However we might want to clean up the remaining issues before releasing 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
falter-1.3.0
Development

No branches or pull requests
1 participant
@Noki