Skip to content
This repository has been archived by the owner on Aug 15, 2022. It is now read-only.

Added new routes based on the resources provided. Refactored "get" re… #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

odgrace
Copy link

@odgrace odgrace commented Mar 17, 2019

Hi!

I found the library looked a little like what i was after, so i decided to contribute a bit. My first pull request ever - apologies if i have probably changed too much for one single commit. A few pointers:

  • Added 4 new routes based on some API docs. Have tested all with my controller and they seem to work.
  • I refactored all "GET" requests - seemed to be repeating a lot otherwise
  • I have avoided doing filters like you did in "list_clients" - i figure this library is great if you deal with the filtering outside the API
  • you can set verify_ssl globally to a session object so i did that. I'm assuming that a single API object will be made per site - and if the site has proper SSL then you'd only need to set the param once. Thoughts?
  • Also did a few PEP-8 formatting.

The json files are simply transcribing from the API docs site i was using. Eventually i'd make lookups based on these files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants