From a87f031759c53fbc54ee19d8baee885a9399639c Mon Sep 17 00:00:00 2001 From: dornelasnelson Date: Fri, 31 Jan 2025 19:13:17 +0100 Subject: [PATCH] fix: add missing label to IconButton container --- package-lock.json | 101 ++++++++++++++++++ .../experimental/IconButton/IconButton.tsx | 9 +- 2 files changed, 108 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index bf7e84d2..8d88366f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3260,6 +3260,29 @@ "url": "https://github.com/chalk/wrap-ansi?sponsor=1" } }, + "node_modules/@isaacs/fs-minipass": { + "version": "4.0.1", + "resolved": "https://registry.npmjs.org/@isaacs/fs-minipass/-/fs-minipass-4.0.1.tgz", + "integrity": "sha512-wgm9Ehl2jpeqP3zw/7mo3kRHFp5MEDhqAdwy1fTGkHAwnkGOVsgpvQhL8B5n1qlb01jV3n/bI0ZfZp5lWA1k4w==", + "dev": true, + "license": "ISC", + "dependencies": { + "minipass": "^7.0.4" + }, + "engines": { + "node": ">=18.0.0" + } + }, + "node_modules/@isaacs/fs-minipass/node_modules/minipass": { + "version": "7.1.2", + "resolved": "https://registry.npmjs.org/minipass/-/minipass-7.1.2.tgz", + "integrity": "sha512-qOOzS1cBTWYF4BH8fVePDBOO9iptMnGUEZwNc/cMWnTV2nVLZ7VoNWEPHkYczZA0pdoA7dl6e7FL659nX9S2aw==", + "dev": true, + "license": "ISC", + "engines": { + "node": ">=16 || 14 >=14.17" + } + }, "node_modules/@istanbuljs/load-nyc-config": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/@istanbuljs/load-nyc-config/-/load-nyc-config-1.1.0.tgz", @@ -26921,6 +26944,20 @@ "inBundle": true, "license": "MIT" }, + "node_modules/npm/node_modules/jackspeak": { + "version": "4.0.2", + "dev": true, + "license": "BlueOak-1.0.0", + "dependencies": { + "@isaacs/cliui": "^8.0.2" + }, + "engines": { + "node": "20 || >=22" + }, + "funding": { + "url": "https://github.com/sponsors/isaacs" + } + }, "node_modules/npm/node_modules/jsbn": { "version": "0.1.1", "dev": true, @@ -27743,6 +27780,31 @@ "node": ">=0.10.0" } }, + "node_modules/npm/node_modules/path-scurry": { + "version": "2.0.0", + "dev": true, + "license": "BlueOak-1.0.0", + "dependencies": { + "lru-cache": "^11.0.0", + "minipass": "^7.1.2" + }, + "engines": { + "node": "20 || >=22" + }, + "funding": { + "url": "https://github.com/sponsors/isaacs" + } + }, + "node_modules/npm/node_modules/path-scurry/node_modules/minipass": { + "version": "7.1.2", + "resolved": "https://registry.npmjs.org/minipass/-/minipass-7.1.2.tgz", + "integrity": "sha512-qOOzS1cBTWYF4BH8fVePDBOO9iptMnGUEZwNc/cMWnTV2nVLZ7VoNWEPHkYczZA0pdoA7dl6e7FL659nX9S2aw==", + "dev": true, + "license": "ISC", + "engines": { + "node": ">=16 || 14 >=14.17" + } + }, "node_modules/npm/node_modules/performance-now": { "version": "2.1.0", "dev": true, @@ -38586,6 +38648,22 @@ } } }, + "@isaacs/fs-minipass": { + "version": "https://registry.npmjs.org/@isaacs/fs-minipass/-/fs-minipass-4.0.1.tgz", + "integrity": "sha512-wgm9Ehl2jpeqP3zw/7mo3kRHFp5MEDhqAdwy1fTGkHAwnkGOVsgpvQhL8B5n1qlb01jV3n/bI0ZfZp5lWA1k4w==", + "dev": true, + "requires": { + "minipass": "^7.0.4" + }, + "dependencies": { + "minipass": { + "version": "7.1.2", + "resolved": "https://registry.npmjs.org/minipass/-/minipass-7.1.2.tgz", + "integrity": "sha512-qOOzS1cBTWYF4BH8fVePDBOO9iptMnGUEZwNc/cMWnTV2nVLZ7VoNWEPHkYczZA0pdoA7dl6e7FL659nX9S2aw==", + "dev": true + } + } + }, "@istanbuljs/load-nyc-config": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/@istanbuljs/load-nyc-config/-/load-nyc-config-1.1.0.tgz", @@ -56214,6 +56292,13 @@ "bundled": true, "dev": true }, + "jackspeak": { + "version": "4.0.2", + "dev": true, + "requires": { + "@isaacs/cliui": "^8.0.2" + } + }, "jsbn": { "version": "0.1.1", "bundled": true, @@ -56815,6 +56900,22 @@ "bundled": true, "dev": true }, + "path-scurry": { + "version": "2.0.0", + "dev": true, + "requires": { + "lru-cache": "^11.0.0", + "minipass": "^7.1.2" + }, + "dependencies": { + "minipass": { + "version": "7.1.2", + "resolved": "https://registry.npmjs.org/minipass/-/minipass-7.1.2.tgz", + "integrity": "sha512-qOOzS1cBTWYF4BH8fVePDBOO9iptMnGUEZwNc/cMWnTV2nVLZ7VoNWEPHkYczZA0pdoA7dl6e7FL659nX9S2aw==", + "dev": true + } + } + }, "performance-now": { "version": "2.1.0", "bundled": true, diff --git a/src/components/experimental/IconButton/IconButton.tsx b/src/components/experimental/IconButton/IconButton.tsx index 0a5ec73e..837a4d44 100644 --- a/src/components/experimental/IconButton/IconButton.tsx +++ b/src/components/experimental/IconButton/IconButton.tsx @@ -14,7 +14,7 @@ export interface IconButtonProps extends ButtonProps { label: string; } -const StandardIconContainer = styled(Button)>` +const StandardIconContainer = styled(Button)>` height: 2.5rem; width: 2.5rem; border-radius: 100%; @@ -123,11 +123,16 @@ export const IconButton = ({ isDisabled={isDisabled} isActive={isActive} isPending={isLoading} + label={label} {...restProps} > <> {isLoading ? ( - + ) : ( )}