Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflicts with 3-way merge #71

Open
tiran opened this issue Dec 12, 2017 · 1 comment
Open

Resolve merge conflicts with 3-way merge #71

tiran opened this issue Dec 12, 2017 · 1 comment

Comments

@tiran
Copy link
Member

tiran commented Dec 12, 2017

ipatool doesn't allow 3-way merge to resolve merge conflicts:

$ ./ipatool pr-push 1363 -r abok
Reviewer: Alexander Bokovoy <[email protected]>
Will apply 1 patches to: master
Fetching...
Aplying to master: Replace nose with unittest and pytest
git am
Applying: Replace nose with unittest and pytest
Patch failed at 0001 Replace nose with unittest and pytest
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: ipatests/test_webui/ui_driver.py:220
error: ipatests/test_webui/ui_driver.py: patch does not apply
→ 128
Command failed

The same merge works fine with rebase:

$ git rebase upstream/master 
First, rewinding head to replay your work on top of it...
Applying: Replace nose with unittest and pytest
Using index info to reconstruct a base tree...
M       ipatests/test_webui/ui_driver.py
Falling back to patching base and 3-way merge...
Auto-merging ipatests/test_webui/ui_driver.py

PR freeipa/freeipa#1363

@frasertweedale
Copy link
Contributor

@tiran do you still want this feature in ipatool itself, or leave it as something to be handled separately by the PR author?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants