Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdconfig: remove the "cluster" option. #1271

Closed
wants to merge 1 commit into from

Conversation

asomers
Copy link
Member

@asomers asomers commented Jun 1, 2024

It's never had any effect. The kernel ignores it. Remove it from the documentation. But continue to parse it on the command line, for backwards-compatibility.

It's never had any effect.  The kernel ignores it.  Remove it from the
documentation.  But continue to parse it on the command line, for
backwards-compatibility.
@asomers asomers requested a review from bsdimp June 1, 2024 18:39
Copy link
Member

@bsdimp bsdimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Maybe, if you really want to, warn about this and #ifdef the detection < 16 or something... Or not and commit as is... (also, should I let you land this, or would you like me to land, I'm good either way).

@asomers
Copy link
Member Author

asomers commented Jun 1, 2024

Nice cleanup. Maybe, if you really want to, warn about this and #ifdef the detection < 16 or something... Or not and commit as is... (also, should I let you land this, or would you like me to land, I'm good either way).

Warn where, in the mdconfig binary? And I'm comfortable landing it myself.

@bsdimp
Copy link
Member

bsdimp commented Jun 1, 2024

Nice cleanup. Maybe, if you really want to, warn about this and #ifdef the detection < 16 or something... Or not and commit as is... (also, should I let you land this, or would you like me to land, I'm good either way).

Warn where, in the mdconfig binary? And I'm comfortable landing it myself.

Yes. warnx("Option cluster ignored");

Cool. I'll let you do the landing then. No worries. I've tagged it with 'test-only' so I won't land it.

freebsd-git pushed a commit that referenced this pull request Jun 1, 2024
It's never had any effect.  The kernel ignores it.  Remove it from the
documentation.  But continue to parse it on the command line, for
backwards-compatibility.

Reviewed by:	imp
Pull Request:	#1271
@asomers
Copy link
Member Author

asomers commented Jun 1, 2024

Committed in e461c7b .

@asomers asomers closed this Jun 1, 2024
@asomers asomers deleted the MD_CLUSTER branch June 1, 2024 23:41
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Sep 4, 2024
It's never had any effect.  The kernel ignores it.  Remove it from the
documentation.  But continue to parse it on the command line, for
backwards-compatibility.

Reviewed by:	imp
Pull Request:	freebsd/freebsd-src#1271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants