Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modulation status to the param indication extension #319

Open
robbert-vdh opened this issue Apr 19, 2023 · 1 comment
Open

Add modulation status to the param indication extension #319

robbert-vdh opened this issue Apr 19, 2023 · 1 comment

Comments

@robbert-vdh
Copy link
Member

The reasoning behind not doing this was that you could already tell that a parameter is being modulated by looking at the param modulation events. This is true if the parameter is currently being modulated, but there's no way to tell if a parameter has a modulation assignment if that modulation offset is currently zero. For consistency with the automation states, I think param indication should also have CLAP_PARAM_INDICATION_MODULATION_NONE and CLAP_PARAM_INDICATION_MODULATION_PRESENT flags.

@skei
Copy link

skei commented Feb 1, 2024

it could also be nice to know if a parameter is modulated mono- or polyphonically.. for mono, we could indicate the current value on the gui knob, but polyphonically (or via multiple modulators) it could make more sense to draw the range of modulation instead.. or in a different color, blue for mono/single, green for poly/multiple..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants