From b94ee402311d577a80cb0e0d08d675180978e2c9 Mon Sep 17 00:00:00 2001
From: Dan Wallis <mrdanwallis@gmail.com>
Date: Fri, 25 Nov 2022 11:38:21 +0000
Subject: [PATCH] Appease coding standard

See also https://github.com/magento/magento-coding-standard/pull/347
---
 .../Magento/User/view/adminhtml/web/js/roles-tree.js  | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/app/code/Magento/User/view/adminhtml/web/js/roles-tree.js b/app/code/Magento/User/view/adminhtml/web/js/roles-tree.js
index 82cdc4ac49feb..aeb14c43578f3 100644
--- a/app/code/Magento/User/view/adminhtml/web/js/roles-tree.js
+++ b/app/code/Magento/User/view/adminhtml/web/js/roles-tree.js
@@ -47,7 +47,9 @@ define([
             const $tree = $.jstree.reference(this.element),
                 collapseAllButton = document.createElement('button'),
                 expandAllButton = document.createElement('button'),
-                expandUsedButton = document.createElement('button');
+                expandUsedButton = document.createElement('button'),
+                parent = this.element[0],
+                ul = this.element.find('ul')[0];
 
             collapseAllButton.innerText = $.mage.__('Collapse all');
             collapseAllButton.addEventListener('click', function () {
@@ -62,11 +64,13 @@ define([
             expandUsedButton.innerText = $.mage.__('Expand selected');
             expandUsedButton.addEventListener('click', function () {
                 const hasOpened = [];
+
                 $tree.get_checked(true).forEach(function (node) {
                     $tree.open_node(node);
                     hasOpened.push(node.id);
                     for (let i = 0; i < node.parents.length - 1; i++) {
                         const id = node.parents[i];
+
                         if (!hasOpened.includes(id)) {
                             $tree.open_node($tree.get_node(id));
                             hasOpened.push(id);
@@ -78,12 +82,9 @@ define([
             this.buttons = [
                 collapseAllButton,
                 expandAllButton,
-                expandUsedButton,
+                expandUsedButton
             ];
 
-            const parent = this.element[0],
-                ul = this.element.find('ul')[0];
-
             this.buttons.forEach(function (button) {
                 button.type = 'button';
                 parent.insertBefore(button, ul);