Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit handling #293

Open
dobesv opened this issue Apr 5, 2020 · 1 comment
Open

Rate limit handling #293

dobesv opened this issue Apr 5, 2020 · 1 comment

Comments

@dobesv
Copy link

dobesv commented Apr 5, 2020

Does this automatically wait and retry if you are hitting rate limits?

@timrichardson
Copy link
Contributor

timrichardson commented Jun 21, 2021

It doesn't. If we could pass a requests. session object into the constructor, we could provide a retry session, which is what I do on the APIs I write myself. In this case we should strictly limit retries to short term rate error problems (no point retrying if the limit exceeded is the daily limit) which would need some more specific retry handling, and I think I would be very conservative and avoid retrying for other errors.

In the meantime, the tenacity library is a work-around (https://pypi.org/project/tenacity/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants