From 40c3ceac6380656e0ba9202e7996e164c6d331a1 Mon Sep 17 00:00:00 2001 From: David Date: Thu, 19 Sep 2024 16:25:15 +0200 Subject: [PATCH] fix: don't access db unnecessarily --- hrms/overrides/employee_payment_entry.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py index d81df71563..2d7b3644c6 100644 --- a/hrms/overrides/employee_payment_entry.py +++ b/hrms/overrides/employee_payment_entry.py @@ -65,7 +65,10 @@ def set_missing_ref_details( continue if field == "exchange_rate" or not d.get(field) or force: - d.db_set(field, value) + if self.get("_action") in ("submit", "cancel"): + d.db_set(field, value) + else: + d.set(field, value) @frappe.whitelist()